Modernize to Java 17 and Spring Boot 3.3 - #77
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…d output Co-Authored-By: Joe Benson <joe.benson@cognition.ai>
Co-Authored-By: Joe Benson <joe.benson@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the legacy Java 8 / Spring Boot 2.0.2 (2018) app to Java 17 / Spring Boot 3.3.13, verified end-to-end:
mvn clean packagesucceeds on JDK 17 and the app boots with all/topicCRUD endpoints working against the in-memory H2 store.Key changes beyond version bumps:
pom.xml:packaging pom → jar(the old packaging skipped compilation entirely, somvn packagenever produced a runnable jar); droppedspring-boot-properties-migrator.build.gradle: migrated frombuildscript+compile/testCompileto the plugins DSL withimplementation/testImplementationand a Java 17 toolchain.Application: replaced removed-in-Spring-6jdbcTemplate.query(sql, Object[], RowMapper)with the varargs form; the startup quote fetch now targets the live quoters endpoint and degrades gracefully (log.warn) instead of crashing startup when unreachable (the oldgturnquist-quoters.cfapps.iohost is defunct).target/build output and fixed.gitignore.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/58e031ae89be4be3b6a19a88ff577c5a
Requested by: @joebensoncog97
Note
Devin errored when opening this Pull Request as joebensoncog97.
As a fallback, Devin opened this PR as itself.
Devin Review